Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added quick mention of how to use dockerignore #468

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Added quick mention of how to use dockerignore #468

merged 1 commit into from
Mar 15, 2022

Conversation

AlexejPenner
Copy link
Contributor

Describe changes

I saw that our docs don't mention dockerignore anywhere, so I added a small paragraph to explain how to include one in general.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@AlexejPenner AlexejPenner requested a review from schustmi March 15, 2022 10:58
@AlexejPenner AlexejPenner changed the base branch from main to develop March 15, 2022 10:58
@github-actions github-actions bot added internal To filter out internal PRs and issues documentation Improvements or additions to documentation labels Mar 15, 2022
@AlexejPenner AlexejPenner merged commit b4cba79 into develop Mar 15, 2022
@AlexejPenner AlexejPenner deleted the docs/add-mention-of-dockerignore branch March 15, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-zenml michael-zenml michael-zenml approved these changes

@schustmi schustmi Awaiting requested review from schustmi

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexejPenner @michael-zenml