Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore type of any tfx proto file #453

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Ignore type of any tfx proto file #453

merged 1 commit into from
Mar 10, 2022

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Mar 8, 2022 •
edited
Loading

Describe changes

I configured mypy to not follow imports (= import them as Any which prevents type checking) for any tfx.proto.* files. Until now, we had to manually add an ignore statement for any of the proto types which is now not necessary anymore.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi requested review from htahir1 and jwwwb March 8, 2022 14:33
@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Mar 8, 2022
htahir1
htahir1 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok convenient!

@bcdurak
Copy link
Contributor

bcdurak commented Mar 9, 2022

Beautiful!

jwwwb
jwwwb approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@jwwwb jwwwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should save some effort in the future!

@schustmi schustmi merged commit 24597f6 into develop Mar 10, 2022
@schustmi schustmi deleted the feature/mypy-proto-ignore branch March 10, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwwwb jwwwb jwwwb approved these changes

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schustmi @bcdurak @htahir1 @jwwwb