Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when provisioning local kubeflow resources with a non-local container registry. #442

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Feb 28, 2022

Describe changes

Improve error message when provisioning local kubeflow resources with a non-local container registry.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi requested review from strickvl and htahir1 February 28, 2022 20:26
@schustmi schustmi changed the title Bugfix/eng 558 local registry port Improve error message when provisioning local kubeflow resources with a non-local container registry. Feb 28, 2022
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Feb 28, 2022
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I dont really see the error something like "For a remote stack, you must provision the stack yourself. Please follow the guide in the docs to get set up" or something

@schustmi
Copy link
Contributor Author

schustmi commented Mar 1, 2022

I implemented the reverse essentially: Instead of telling them that zenml stack up isn't possible with non-local components, the error message tells users to change to a local container registry if they want to provision the local kubeflow deployment (the kubeflow orchestrator itself is agnostic to local/remote settings).

@schustmi
Copy link
Contributor Author

schustmi commented Mar 7, 2022

@strickvl Is this good to merge in your opinion?

@schustmi schustmi merged commit 6ca3e5e into develop Mar 7, 2022
@schustmi schustmi deleted the bugfix/ENG-558-local-registry-port branch March 7, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants