Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable generic step inputs and outputs #440

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Enable generic step inputs and outputs #440

merged 2 commits into from
Mar 8, 2022

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Feb 28, 2022 •
edited
Loading

Describe changes

Enable generic step inputs and outputs

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi requested review from htahir1 and bcdurak February 28, 2022 12:17
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Feb 28, 2022
htahir1
htahir1 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval when python 3.6 is out

bcdurak
bcdurak approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@schustmi schustmi merged commit a62bdd9 into develop Mar 8, 2022
@schustmi schustmi deleted the bugfix/ENG-493-step-output-type-annotation branch March 8, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdurak bcdurak bcdurak approved these changes

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schustmi @htahir1 @bcdurak