Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix httplib to 0.19 and pyparsing to 2.4 #426

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix httplib to 0.19 and pyparsing to 2.4 #426

merged 1 commit into from
Feb 23, 2022

Conversation

jwwwb
Copy link
Contributor

@jwwwb jwwwb commented Feb 22, 2022

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Briefly describe the changes you have introduced.

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Feb 22, 2022
htahir1
htahir1 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure they are the right versions? Were we abel to reproduce the error? If yes, then LGTM before release!

@htahir1 htahir1 marked this pull request as ready for review February 23, 2022 11:16
@htahir1 htahir1 merged commit 5e05aa7 into develop Feb 23, 2022
@htahir1 htahir1 deleted the bugfix/ENG-468-pyparsing-httplib2-dependency-conflict branch February 23, 2022 11:16
@strickvl strickvl mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwwwb @htahir1