Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concepts back into glossary #425

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

strickvl
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Added concepts back into glossary, sorted alphabetically.

(I removed some code examples to make them concise. I also didn't spend too much time thinking through what concepts are missing. I figure we'll go through these properly when we redo the website / messaging etc post-retreat).

@strickvl strickvl added documentation Improvements or additions to documentation internal To filter out internal PRs and issues labels Feb 22, 2022
@strickvl strickvl changed the base branch from main to develop February 22, 2022 16:41
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! we should add services to this when its done?

@strickvl
Copy link
Contributor Author

@htahir1 yes I feel like there will be a few changes / additions to this that will come. but this is good enough for the short-term. A lot of these concepts were written by me when I didn't really know / understand much so they can be made much more concise.

@htahir1
Copy link
Contributor

htahir1 commented Feb 22, 2022

@htahir1 Then its LGTM!

@strickvl strickvl merged commit 1704d57 into develop Feb 23, 2022
@strickvl strickvl deleted the content/ENG-512-glossary branch February 23, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants