Quickstart code in docs fixed #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htahir1
reviewed
Feb 3, 2022
| importer, | ||
| trainer, | ||
| evaluator, | ||
| importer, |
There was a problem hiding this comment.
I think these are extra indents by mistake?
| return model | ||
|
|
||
|
|
||
| @step | ||
| def evaluator( | ||
| X_test: np.ndarray, |
There was a problem hiding this comment.
I actually really liked the capitalized X_test for X matrices. I think its a convention (or atleast that how I learned it)
There was a problem hiding this comment.
Alright, I can return it to capitalized
|
@htahir1 I addressed the issues you raised :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
Code was actually failing, reformulated a bit, removed mention of git