Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicated Section within docs #379

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Removed duplicated Section within docs #379

merged 1 commit into from
Jan 31, 2022

Conversation

AlexejPenner
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

It seems like the Step Context session was duplicated during a merge (https://docs.zenml.io/v/docs/features/step-fixtures)

@AlexejPenner AlexejPenner requested a review from htahir1 January 31, 2022 14:58
@AlexejPenner AlexejPenner added bug Something isn't working internal To filter out internal PRs and issues labels Jan 31, 2022
@AlexejPenner
Copy link
Contributor Author

We'll also need to backport this into 0.6.0

htahir1
htahir1 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How'd that get in there... we can leave it for 0.6.0 if its too much hassle.

@AlexejPenner
Copy link
Contributor Author

How'd that get in there... we can leave it for 0.6.0 if its too much hassle.

Pretty sure it happened during a merge, line 70 still had the hash in it:

>>>>>>> 9633c5509ebaaa6abde3bfcfdf0b8ca4b471d3bd

@htahir1 htahir1 added the documentation Improvements or additions to documentation label Jan 31, 2022
@AlexejPenner AlexejPenner merged commit f0450c6 into develop Jan 31, 2022
@AlexejPenner AlexejPenner deleted the bugfix/remove_duplicated_page_content branch January 31, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexejPenner @htahir1