Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local airflow example #366

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Fix local airflow example #366

merged 3 commits into from
Feb 2, 2022

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Jan 27, 2022 •
edited
Loading

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Fix airflow orchestrator and local airflow example

@schustmi schustmi requested a review from alex-zenml January 27, 2022 12:56
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Jan 27, 2022
AlexejPenner
AlexejPenner previously approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the air flow again!

@AlexejPenner AlexejPenner self-requested a review January 28, 2022 10:19
AlexejPenner
AlexejPenner reviewed Jan 28, 2022
View reviewed changes
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running it locally it did not work - lets investigate before we merge

@AlexejPenner AlexejPenner dismissed their stale review January 28, 2022 10:20

Not running locally fo rme

alex-zenml
alex-zenml approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@alex-zenml alex-zenml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working now, given a fresh environment.

@htahir1
Copy link
Contributor

htahir1 commented Jan 28, 2022

I also checked on WSL (Linux on Windows) and it works like a charm

AlexejPenner
AlexejPenner approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new venv -> poetry installed you branch -> followed README instructions of the example -> runs with no issues 😄 -> lgtd 😉

@schustmi schustmi merged commit ded22cd into develop Feb 2, 2022
@schustmi schustmi deleted the bugfix/ENG-379-airflow-example branch February 2, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-zenml alex-zenml alex-zenml approved these changes

@AlexejPenner AlexejPenner AlexejPenner approved these changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schustmi @htahir1 @AlexejPenner @alex-zenml