Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 artifact store and filesystem #359

Merged
merged 11 commits into from
Jan 26, 2022
Merged

Add S3 artifact store and filesystem #359

merged 11 commits into from
Jan 26, 2022

Conversation

schustmi
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Add S3 artifact store and filesystem

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Jan 26, 2022
@schustmi schustmi marked this pull request as ready for review January 26, 2022 13:15
@schustmi schustmi requested review from htahir1 and jwwwb January 26, 2022 13:15
htahir1
htahir1 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing!

@schustmi schustmi merged commit d4f442c into develop Jan 26, 2022
@schustmi schustmi deleted the feature/s3-artifact-store branch January 26, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdurak bcdurak bcdurak approved these changes

@htahir1 htahir1 htahir1 approved these changes

@jwwwb jwwwb Awaiting requested review from jwwwb

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schustmi @htahir1 @bcdurak