Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK docs rendering with proper directory structure and links #3374

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

strickvl
Copy link
Contributor

This PR addresses the issue with the SDK documentation where clicking sidebar links would take users to a directory index page instead of directly to the content page.

Changes Made

  1. Bumped MkDocs and related packages to latest versions:

    • mkdocs: ^1.2.3 → ^1.6.1
    • mkdocs-material: ^8.1.7 → 9.6.5
    • mkdocs-awesome-pages-plugin: ^2.6.1 → 2.10.1
    • mkdocstrings: ^0.17.0 → ^0.28.1 (with Python extras)
    • mike: ^1.1.2 → 2.1.3
  2. Fixed capitalization in API docs title ('Api' → 'API')

  3. Improved docs structure and navigation:

    • Updated to create a proper directory structure with index.md files
    • Modified link generation to point directly to index.md files
    • Set in MkDocs configuration

Previous Issue

When clicking a link in the sidebar, users would be taken to a directory listing page, requiring an additional click to reach the actual content.

Fixed Behavior

Links in the sidebar now take users directly to the content pages without requiring extra clicks.

Testing

Locally generated and tested the documentation site to verify that links work correctly.

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues labels Feb 24, 2025
@strickvl strickvl requested a review from htahir1 February 24, 2025 19:26
Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@strickvl strickvl changed the base branch from main to develop February 24, 2025 19:26
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works im happy

strickvl and others added 2 commits February 25, 2025 16:21
…conflict

Updated mkdocs-autorefs version constraint from >=0.4.1,<1.0.0 to >=1.4.0,<2.0.0 to
resolve a dependency conflict with mkdocstrings 0.28.2, which requires mkdocs-autorefs>=1.4.

🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants