-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stefan/eng 264 evidently integration #310
Conversation
39d7ab6
to
6b87e6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing I noticed on this. It was before you did one of your recent rebases, so I'm not sure if that also included a fix.
try: | ||
from IPython.core.display import HTML, display | ||
|
||
display(HTML(html_)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a Mac, the try
block always runs. I get the following printed to my terminal at the end:
<IPython.core.display.HTML object>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-zenml This should be fixed with my latest commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
0b3a8be
to
bea6ede
Compare
* modify evidently step to output a Dashboard and a Profile * implement visualizer for evidently HTML reports generated from Dasboards * add drift detection step to evidently example * created a DataAnalysisArtifact to help with identifying the HTML report artifact in the visualizer * add a jupyter notebook to the evidently drift example
bea6ede
to
7db5b6d
Compare
Running unit tests before integration tests to keep them from intefering with eachother.
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
Extends the ZenML Evidently integration with support for visualizations