Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stefan/eng 264 evidently integration #310

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

stefannica
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Extends the ZenML Evidently integration with support for visualizations

@stefannica stefannica added the internal To filter out internal PRs and issues label Jan 12, 2022
@stefannica stefannica force-pushed the stefan/ENG-264-evidently-integration branch from 39d7ab6 to 6b87e6b Compare January 12, 2022 14:40
Copy link
Contributor

@alex-zenml alex-zenml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I noticed on this. It was before you did one of your recent rebases, so I'm not sure if that also included a fix.

try:
from IPython.core.display import HTML, display

display(HTML(html_))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a Mac, the try block always runs. I get the following printed to my terminal at the end:

<IPython.core.display.HTML object>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-zenml This should be fixed with my latest commits

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@stefannica stefannica force-pushed the stefan/ENG-264-evidently-integration branch from 0b3a8be to bea6ede Compare January 12, 2022 15:48
Base automatically changed from alex/ENG-264-evidently-integration to develop January 12, 2022 15:56
* modify evidently step to output a Dashboard and a Profile
* implement visualizer for evidently HTML reports generated from
Dasboards
* add drift detection step to evidently example
* created a DataAnalysisArtifact to help with identifying the HTML
report artifact in the visualizer
* add a jupyter notebook to the evidently drift example
@stefannica stefannica force-pushed the stefan/ENG-264-evidently-integration branch from bea6ede to 7db5b6d Compare January 12, 2022 16:09
Running unit tests before integration tests to keep them from
intefering with eachother.
@stefannica stefannica merged commit 799e6f5 into develop Jan 13, 2022
@stefannica stefannica deleted the stefan/ENG-264-evidently-integration branch January 13, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants