Run KFP container as local user/group if local #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files and folders in the local repositories (e.g. database, .system TFX directories) are shared between different runs of the same pipeline or of different pipelines. If pipelines are run in the context of different users, such as when switching between KFP and the local orchestrators, this can create problems with permissions. Running the KFP containers with the same UID/GID as the local user maintains permissions consistent across orchestrators. Signed-off-by: Stefan Nica <stefan@zenml.io>
schustmi
reviewed
Jan 10, 2022
I don't think we even support KFP as a local orchestrator on Windows, but even if we did, the Windows host should ignore file permissions set on the KFP side. |
AlexejPenner
approved these changes
Jan 10, 2022
cb9f5d7 to
ee0942d
Compare
|
looks good to me as well! |
bcdurak
approved these changes
Jan 10, 2022
schustmi
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
Some files and folders in the local repositories (e.g. database,
.system TFX directories) are shared between different runs of the
same pipeline or of different pipelines. If pipelines are run
in the context of different users, such as when switching between
KFP and the local orchestrators, this can create problems with
permissions.
Running the KFP containers with the same UID/GID as the local
user maintains permissions consistent across orchestrators.