Baris/eng 303 artifact param naming bug #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schustmi
requested changes
Jan 10, 2022
src/zenml/steps/base_step.py
Outdated
| set(cls.OUTPUT_SIGNATURE) | ||
| ) | ||
| if shared_input_output_keys: | ||
| all_keys = list(cls.INPUT_SIGNATURE) + list(cls.OUTPUT_SIGNATURE) |
There was a problem hiding this comment.
I guess it's not super relevant in this case because the list of all keys will never be too large, but I'd still suggest using a collections.Counter object to count the occurrences of keys to make it a little more expressive.
There was a problem hiding this comment.
@schustmi thank you for the tip. I have added a new version utilizing the Counter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
A small bug fix that adds the parameter names in the config to the duplicate name check in the metaclass of the BaseStep