Baris/eng 293 remove git init #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htahir1
reviewed
Jan 5, 2022
| @@ -50,13 +49,17 @@ class Integration(metaclass=IntegrationMeta): | |||
| def check_installation(cls) -> bool: | |||
| """Method to check whether the required packages are installed""" | |||
| try: | |||
| for req, command in cls.SYSTEM_REQUIREMENTS.items(): | |||
| for requirement, command in cls.SYSTEM_REQUIREMENTS.items(): | |||
src/zenml/cli/__init__.py
Outdated
| initialize the directory with ZenML’s own config and resource management | ||
| tools. Type: | ||
| When you begin a project, initialize the directory with ZenML’s | ||
| own config and resource management tools. Type: |
There was a problem hiding this comment.
Isnt this missing something?
There was a problem hiding this comment.
I have changed it a bit more to reflect the current situation.
|
@htahir1 Thanks for the tip regarding the docs. I have also changed the corresponding section. I hope it is a bit clearer now. |
htahir1
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
the instructions to do
git initwhile creating a ZenML repository have been removed from the examples and the docs