-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexej/eng 267 additional example run implementations #286
Merged
AlexejPenner
merged 12 commits into
main
from
alexej/eng-267-additional-example-run-implementations
Jan 3, 2022
Merged
Alexej/eng 267 additional example run implementations #286
AlexejPenner
merged 12 commits into
main
from
alexej/eng-267-additional-example-run-implementations
Jan 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htahir1
requested changes
Dec 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really look work! Just a few suggestions
schustmi
reviewed
Dec 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small remark apart from the things @htahir1 already mentioned
…onal-example-run-implementations
AlexejPenner
deleted the
alexej/eng-267-additional-example-run-implementations
branch
January 3, 2022 09:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
Implementing zenml example run for standard_interfaces, functional_api and class_based_api.
In case there are multiple python executables in an example the alphanumeric last file is chosen. As long as we stick to naming like: chapter_1, chapter_2 ... this will make sure to always run the most complete last chapter