Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexej/eng 267 additional example run implementations #286

Merged

Conversation

AlexejPenner
Copy link
Contributor

@AlexejPenner AlexejPenner commented Dec 30, 2021

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Implementing zenml example run for standard_interfaces, functional_api and class_based_api.

In case there are multiple python executables in an example the alphanumeric last file is chosen. As long as we stick to naming like: chapter_1, chapter_2 ... this will make sure to always run the most complete last chapter

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 30, 2021
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really look work! Just a few suggestions

examples/class_based_api/chapter_1.py Outdated Show resolved Hide resolved
tests/integration/test_examples.py Outdated Show resolved Hide resolved
examples/class_based_api/chapter_3.py Outdated Show resolved Hide resolved
examples/class_based_api/chapter_2.py Outdated Show resolved Hide resolved
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small remark apart from the things @htahir1 already mentioned

examples/standard_interfaces/README.md Show resolved Hide resolved
@AlexejPenner AlexejPenner merged commit d48459d into main Jan 3, 2022
@AlexejPenner AlexejPenner deleted the alexej/eng-267-additional-example-run-implementations branch January 3, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants