Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pre commit in local environment #260

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Run pre commit in local environment #260

merged 3 commits into from
Dec 21, 2021

Conversation

schustmi
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Run pre commit in local environment

@schustmi schustmi requested a review from htahir1 December 21, 2021 14:29
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 21, 2021
htahir1
htahir1 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool - at least now we dont have two standards for these tools. Can we also quickly update our internal Notion accordingly: https://www.notion.so/zenml/Dev-Tools-4ff3b06d06c349eea98fbd5923f15e78#4d27ba236ea94cbb879cab2ae8a38221

Otherwise looks good

@schustmi schustmi merged commit e980e3f into main Dec 21, 2021
@schustmi schustmi deleted the michael/ENG-247-pre-commit branch December 21, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schustmi @htahir1