Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubeflow dockerignore #249

Merged
merged 9 commits into from
Dec 21, 2021
Merged

Kubeflow dockerignore #249

merged 9 commits into from
Dec 21, 2021

Conversation

schustmi
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Add option to specify dockerignore file when running a pipeline in kubeflow
  • ZenML repo no longer requires a git repo
  • All Stacks + their components now load from the correct repository which they are referenced from, not the one found at the working directory

@schustmi schustmi requested a review from htahir1 December 20, 2021 09:18
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 20, 2021
htahir1
htahir1 requested changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright - what a PR! Its amazing how you were able to fix the mess of the LocalService that I created. Will definitely improve it in the future. Just have two small change request, but otherwise feel free to merge after fixing!

src/zenml/integrations/kubeflow/docker_utils.py
gzip=False,
extra_files=extra_files,
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would add an else with a log that you did not specify a dockerignore and a .dockerignore does not exist at root, so we are building all the context with all the files

src/zenml/integrations/kubeflow/docker_utils.py Outdated
@@ -97,6 +176,9 @@ def build_docker_image(
image_name: The name to use for the created docker image.
dockerfile_path: Optional path to a dockerfile. If no value is given,
a temporary dockerfile will be created.
dockerignore_path: Optional path to a dockerignore file. If no value is
given, the .dockerignore in the root of the build context will be
used if it exists.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add: If that doesn't exist, then we create the context with all files.

@schustmi schustmi merged commit 71a5571 into main Dec 21, 2021
@schustmi schustmi deleted the michael/ENG-237-kubeflow-dockerignore branch December 21, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 requested changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schustmi @htahir1