Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubeflow guide #230

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Update kubeflow guide #230

merged 7 commits into from
Dec 14, 2021

Conversation

schustmi
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Update the last chapter of the low level guide

alex-zenml
alex-zenml suggested changes Dec 14, 2021
View reviewed changes
docs/book/guides/low-level-api/chapter-7.md Outdated Show resolved Hide resolved
docs/book/guides/low-level-api/chapter-7.md Outdated Show resolved Hide resolved
docs/book/guides/low-level-api/chapter-7.md Outdated Show resolved Hide resolved
docs/book/guides/low-level-api/chapter-7.md Outdated Show resolved Hide resolved
docs/book/guides/low-level-api/chapter-7.md Outdated Show resolved Hide resolved
docs/book/guides/low-level-api/chapter-7.md Outdated Show resolved Hide resolved
htahir1
htahir1 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex's changes aside, happy to merge!

@schustmi @alex-zenml
Update docs/book/guides/low-level-api/chapter-7.md
92de692 
Co-authored-by: Alex Strick van Linschoten <90610017+alex-zenml@users.noreply.github.com>
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 14, 2021
schustmi and others added 5 commits December 14, 2021 13:49
@schustmi @alex-zenml
[ci skip] Update docs/book/guides/low-level-api/chapter-7.md
91de7ff 
Co-authored-by: Alex Strick van Linschoten <90610017+alex-zenml@users.noreply.github.com>
@schustmi @alex-zenml
[ci skip] Update docs/book/guides/low-level-api/chapter-7.md
ea44e41 
Co-authored-by: Alex Strick van Linschoten <90610017+alex-zenml@users.noreply.github.com>
@schustmi @alex-zenml
[ci skip] Update docs/book/guides/low-level-api/chapter-7.md
b720493 
Co-authored-by: Alex Strick van Linschoten <90610017+alex-zenml@users.noreply.github.com>
@schustmi @alex-zenml
[ci skip] Update docs/book/guides/low-level-api/chapter-7.md
58cd89b 
Co-authored-by: Alex Strick van Linschoten <90610017+alex-zenml@users.noreply.github.com>
@schustmi @alex-zenml
[ci skip] Update docs/book/guides/low-level-api/chapter-7.md
e657d4b 
Co-authored-by: Alex Strick van Linschoten <90610017+alex-zenml@users.noreply.github.com>
@schustmi schustmi merged commit e937f7d into main Dec 14, 2021
@schustmi schustmi deleted the michael/kubeflow-guide branch December 14, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-zenml alex-zenml alex-zenml requested changes

@alexej-zenml alexej-zenml alexej-zenml approved these changes

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schustmi @htahir1 @alex-zenml @alexej-zenml