Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement base component tests #211

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Implement base component tests #211

merged 3 commits into from
Dec 6, 2021

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Dec 6, 2021

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

  • Remove flawed GlobalConfig test
  • Remove setting analytics when creating a repo
  • Add tests for BaseComponent superfluous argument detection

@schustmi schustmi requested a review from htahir1 December 6, 2021 12:22
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Dec 6, 2021
htahir1
htahir1 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome tests!

@schustmi schustmi merged commit fa354d8 into main Dec 6, 2021
@schustmi schustmi deleted the michael/ENG-219-base-component-tests branch December 6, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schustmi @htahir1