Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker files #169

Merged
merged 6 commits into from
Nov 12, 2021
Merged

Update docker files #169

merged 6 commits into from
Nov 12, 2021

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Nov 11, 2021

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Update existing docker files and create development versions

@schustmi schustmi requested a review from htahir1 November 11, 2021 15:10
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Nov 11, 2021
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Should we have a version with all integrations? Maybe we can create a matrix of images each time?

@schustmi
Copy link
Contributor Author

Yeah some kind of matrix would definitely be nice, especially once we get many integrations. For now I also stayed with a tensorflow base image for the cuda ones (there are cuda images as well, but then every user would have to figure out which pytorch/tf version works with the current zenml cuda image so that's not optimal either)

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then lets merge!

@schustmi schustmi merged commit 03f184b into main Nov 12, 2021
@schustmi schustmi deleted the michael/ENG-15-docker-images branch November 12, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants