Tests for core and cli modules
#149
Conversation
| current_saved_global_examples_repo.git.reset("--hard", "0.5.0") | ||
| runner.invoke(pull, ["-f", "-v", "0.5.1"]) | ||
| result = runner.invoke(list) | ||
| assert "airflow_local" in result.output |
There was a problem hiding this comment.
Shouldn't this call raise an error somehow if the version does not exist?
There was a problem hiding this comment.
@schustmi I didn't understand this. Do you mean that we should add another test to catch this condition (i.e. if the version doesn't exist) or that the currently-written test is doing something unexpected?
There was a problem hiding this comment.
Not sure actually how this should be handled, maybe a warning message that the requested version does not exists and that we fallback to the latest one?
There was a problem hiding this comment.
I've added a warning message.
src/zenml/cli/example.py
Outdated
| readme_content = git_examples_handler.get_example_readme(example_dir) | ||
| click.echo(readme_content) | ||
| except FileNotFoundError: | ||
| error( |
There was a problem hiding this comment.
This might be a bit weird because maybe an example is there but doesnt have a README and it would say the example is not present
tests/cli/test_config.py
Outdated
| assert "local_metadata_store" in result.output | ||
|
|
||
|
|
||
| # test metadata register command actually registers a new metadata store |
There was a problem hiding this comment.
Was leftover from an initial session thinking through the code. Removed now.
|
@schustmi back over to you now. I addressed all your comments. Thanks for the review. It's much better now thanks to them! |
src/zenml/cli/utils.py
Outdated
| @@ -181,3 +184,14 @@ def parse_unknown_options(args: List[str]) -> Dict[str, Any]: | |||
| assert len(p_args) == len(r_args), "Replicated arguments!" | |||
|
|
|||
| return r_args | |||
|
|
|||
|
|
|||
| # def markdown_to_console(markdown: str) -> None: | |||
src/zenml/cli/utils.py
Outdated
| @@ -21,6 +21,9 @@ | |||
|
|
|||
| from zenml.core.base_component import BaseComponent | |||
|
|
|||
| # from rich.console import Console | |||
| f"Example {example_name} is not one of the available options." | ||
| f"\nTo list all available examples, type: `zenml example list`" | ||
| ) | ||
| if path_utils.file_exists(example_dir) and path_utils.is_dir( |
|
@htahir1 done! I'll certainly return to the markdown parser feature. I added it and it works, but I couldn't figure out a good way to test it like we are now testing the non-parsed .md text. I'll add it to the backlog. So much more pleasant an experience compared to what we have currently. |
|
Cool! @schustmi can also take a look and merge then if he thinks everything is fixed :-) |
|
@schustmi LMK if this is what you were thinking about with some kind of warning/notification of the redownload. |
|
@alex-zenml Yes looks good! |
Pre-requisites
Please ensure you have done the following:
Types of changes
Describe changes
Add tests for
coreandclimodulesSome tiny typos and bugs found in
srcfixed alongside.