This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Disable bigint for 64 bit machines #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@jtvd78 I've added an additional test to ensure that i8 values are not cast to BigInteger on 64-bit systems (the test is skipped on non-64bit systems). I'll be merging and releasing shortly; thanks for the contribution! |
jvandort
commented
Dec 28, 2019
| public function tearDown() | ||
| { | ||
| AbstractValue::$USE_BIGINT_FOR_I8 = $this->useBigIntForI8Flag; | ||
| $this->useBigIntForI8Flag = null; |
There was a problem hiding this comment.
I'm curious what the significance of setting useBigIntForI8Flag to null is.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables BigInteger if the machine is 64-bit. Currently, when an i8 type is received from the XMLRPC server, the client converts the value to a BigInteger. But now, if the machine is 64-bit, it will simply convert the value to a standard Integer.