This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Fix memory leak: headers added by the http client are added to the same request object at each request #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers are no longer added every time. They used to be added regardless, which caused the headers array to grow infinitely.
|
This kind of patch still needs test cases to prevent regressions
…On 6 Aug 2017 12:37 PM, "ikdekker" ***@***.***> wrote:
Headers are no longer added every time. They used to be added regardless,
which caused the headers array to grow infinitely.
------------------------------
You can view, comment on, or merge this pull request online at:
#27
Commit Summary
- Fix memory leak in Client.php
File Changes
- *M* src/Client.php
<https://github.com/zendframework/zend-xmlrpc/pull/27/files#diff-0>
(12)
Patch Links:
- https://github.com/zendframework/zend-xmlrpc/pull/27.patch
- https://github.com/zendframework/zend-xmlrpc/pull/27.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakHsavhbp_G8Y_-986TlwwYAkrD-pks5sVZdZgaJpZM4Ousi4>
.
|
[cs] Remove whitespace on empty line
Headers are no longer added every time. They used to be added regardless, which caused the headers array to grow infinitely. [test] Add headers check for content-type & accept [cs] Remove whitespace on empty line
# Conflicts: # test/ClientTest.php
|
I don't know whether the kinds of tests I have added are those you require. However, I am unable to pass unit tests without fails. Locally I pull the original zend-xmlrpc, composer install, then run phpunit. The results are two errors in ZendTest\XmlRpc\Request\HTTPTest::testGetHeaders and ZendTest\XmlRpc\Request\HTTPTest::testGetFullRequest The travic CI, I am not sure about. It gives an error about a VarTag which I don't see. |
|
@ikdekker the Seems related to zendframework/zend-code#128 |
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers are no longer added every time. They used to be added regardless, which caused the headers array to grow infinitely.