This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Updated dependencies and QA toolchain #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PHP => `^5.5 || ^7.0` - zend-stdlib => `^2.7 || ^3.0` - zend-servicemanager was removed (it's not used in either tests or source!) - all other zf deps were updated to known stable, forwards-compatible versions. - Swapped out php-cs-fixer for phpcs - Removed test bootstrap, as unnecessary - Added composer scripts, and updated travis to use them
Many instances of: - multiple class/function definitions within test files (separated into individual TestAsset files) - underscore-prefixed, non-public members (all of these were removed, with the exception of `Server::_fixTypes()`, which is inherited from zend-server) - too long lines - multiple arguments spread incorrectly over multiple lines
weierophinney
added a commit
that referenced
this pull request
Apr 21, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies as follows:
^5.5 || ^7.0^2.7 || ^3.0Updated QA toolchain as follows: