This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Duck type TranslatorAwareInterface #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with zend-mvc 3, i18n features are considered opt-in and optional.
However, several official helpers in zend-view are translator-aware, and
optionally expose translation features if a translator is composed.
This patch does the following:
- Introduces `TranslatorAwareTrait`, which encapsulates the logic for composing
a translator and translation text domain. This logic was duplicated across
multiple helpers already, and is simply extracted from it.
- Updates `FlashMessenger`, `HeadTitle`, and the navigation `AbstractHelper` to:
- Remove the explicit implementation of `TranslatorAwareInterface`.
- Use the new `TranslatorAwareTrait`, effectively duck typing
`TranslatorAwareInterface`.
- Updates `HelperPluginManager` to inject a translator for helpers that either
explicitly implement `TranslatorAwareInterface` or duck type it.
weierophinney
added a commit
that referenced
this pull request
Apr 18, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with zend-mvc 3, i18n features are considered opt-in and optional. However, several official helpers in zend-view are translator-aware, and optionally expose translation features if a translator is composed.
This patch does the following:
TranslatorAwareTrait, which encapsulates the logic for composing a translator and translation text domain. This logic was duplicated across multiple helpers already, and is simply extracted from it.FlashMessenger,HeadTitle, and the navigationAbstractHelperto:TranslatorAwareInterface.TranslatorAwareTrait, effectively duck typingTranslatorAwareInterface.HelperPluginManagerto inject a translator for helpers that either explicitly implementTranslatorAwareInterfaceor duck type it.These changes fix issues when adapting the skeleton application to use the development branch of zend-mvc (future v3).