This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Re-enable zend-modulemanager, -mvc, -navigation, and -session tests on Travis #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Travis Now that each of zend-modulemanager, zend-mvc, zend-navigation, and zend-session have known-stable, forwards-compatible versions available, we can re-enable tests against them on Travis. Doing so exposed some areas where the tests and/or SUTs were not yet correct. These included: - `Zend\View\Helper\Navigation\AbstractHelper` relied on having a shared event manager composed in its event manager, but when lazy-loaded, this does not happen under zend-eventmanager v3. As such, code was added to ensure a shared manager is always present. - The `FlashMessengerFactory` was still pulling the configuration services using the v2 `Config` instead of `config`. - The `HelperPluginManager` was missing an `EventManagerAware` initializer; one was added. - Navigation helper tests were updated to inject a service locator where required.
weierophinney
added a commit
that referenced
this pull request
Mar 2, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 2, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that each of zend-modulemanager, zend-mvc, zend-navigation, and zend-session have known-stable, forwards-compatible versions available, we can re-enable tests against them on Travis.
Doing so exposed some areas where the tests and/or SUTs were not yet correct. These included:
Zend\View\Helper\Navigation\AbstractHelperrelied on having a shared event manager composed in its event manager, but when lazy-loaded, this does not happen under zend-eventmanager v3. As such, code was added to ensure a shared manager is always present.FlashMessengerFactorywas still pulling the configuration services using the v2Configinstead ofconfig.HelperPluginManagerwas missing anEventManagerAwareinitializer; one was added.