This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Test v3 forwards compatibility #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] V3 readiness
- Updated all dependencies to pin to stable series; in the case of those that depend on zend-servicemanager, zend-eventmanager, or zend-stdlib, this pins to versions of those dependencies known to be forwards-compatible with their v3 releases. - Selectively remove dependencies for v3 test builds when the dependency does not have a forwards-compatible version. Currently, that includes zend-modulemanager, zend-mvc, and zend-session.
Instead of shipping a component-specific trait, use the one from zend-eventmanager.
This patch conditionally skips/enables tests based on the presence of zend-mvc as a dependency; currently, this only affects the navigation, flash messenger, and url helpers. Tests run perfectly against v2 dependencies.
zend-modulemanager and zend-session were only present previously so as to pull in development versions for testing. Since we're branching testing based on which versions of eventmanager/servicemanager we want to install, they can be safely removed.
- For the v2 test runs, because zend-session is not a requirement of zend-mvc, but we're testing against a plugin that uses it, we need to add it as a dev requirement. - For v3 runs, that means removing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on #35 to do the following:
Locally, this is running fine, but I want to confirm with Travis.