Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Add method for escaping HTML attributes #164

Closed

Conversation

thexpand
Copy link
Contributor

Covers #107

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To change: drop the current commits from @MWOP from yours branch

@thexpand
Copy link
Contributor Author

@Ocramius I think I've done something wrong.. I tried to rebase onto master, but I believe this is wrong. Maybe I just had to revert the commits from @weierophinney?

@Ocramius
Copy link
Member

Ocramius commented Aug 15, 2018 via email

@thexpand thexpand force-pushed the feature/add-escape-attribute branch from 35f5390 to 45316a2 Compare August 15, 2018 19:39
@thexpand
Copy link
Contributor Author

Thanks, it worked 👍
All good now!

@weierophinney weierophinney added this to the 2.11.0 milestone Dec 6, 2018
weierophinney added a commit that referenced this pull request Dec 6, 2018
@weierophinney
Copy link
Member

Thanks, @thexpand; I have cherry-picked it into develop for release 2.11.0, as it provides additional features on top of the bugfix.

@DennisDobslaf
Copy link

DennisDobslaf commented Jan 11, 2019

If your ie is set to compatibility mode and you want to send
<meta http-equiv="X-UA-Compatible" content="IE=edge"/>
via Zend\View\Helper\HeadMeta like
$headMeta->appendHttpEquiv('X-UA-Compatible', 'IE=edge');
this will lead to the (correct) escaped string
<meta http-equiv="X-UA-Compatible" content="IE&#x3D;edge">
But IE will now fall back to IE 7 Mode (in my case) and because of that, could not find escaped link and script tags.

Can anyone confirm?

As a workaround I send
header('X-UA-Compatible: IE=edge');
before any other, but that does not feel like the right solution.

@froschdesign
Copy link
Member

froschdesign commented Jan 11, 2019

@DennisDobslaf
There is a open issue #180 for that. Please add your comment there, because this pull request is closed. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants