Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Fix: Case-insensitive method annotation for placeholder helper #104

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

localheinz
Copy link
Member

This PR

  • fixes a case-insensitive annotation for the placeholder view helper on PhpRenderer

πŸ’β€β™‚οΈ After updating from ZF2 to ZF3, view rendering fails with

Fatal error: Uncaught exception 'Zend\ServiceManager\Exception\ServiceNotFoundException' with message 'A plugin by the name "placeHolder" was not found in the plugin manager Zend\View\HelperPluginManager' in ~/project/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php:131 

Stack trace: 

#0 ~/project/vendor/zendframework/zend-view/src/Renderer/PhpRenderer.php(373): Zend\ServiceManager\AbstractPluginManager->get('placeHolder', NULL) 
#1 ~/project/vendor/zendframework/zend-view/src/Renderer/PhpRenderer.php(391): Zend\View\Renderer\PhpRenderer->plugin('placeHolder') 
#2 ~/project/module/Project/view/project/layout/default.phtml(67): Zend\View\Renderer\PhpRenderer->__call('placeHolder', Array) 
#3 ~/project/module/Project/view/project/layout/default.phtml(67): Zend\View\Renderer\PhpRenderer->placeHolder('bodyClass' in ~/project/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php on line 131

When modifying the case, PhpStorm complains:

screen shot 2017-01-29 at 23 51 55

@localheinz
Copy link
Member Author

Thank you, @froschdesign!

@weierophinney weierophinney added this to the 2.8.2 milestone Mar 20, 2017
@weierophinney weierophinney self-assigned this Mar 20, 2017
@weierophinney weierophinney merged commit 416d86e into zendframework:master Mar 20, 2017
weierophinney added a commit that referenced this pull request Mar 20, 2017
Fix: Case-insensitive method annotation for placeholder helper
weierophinney added a commit that referenced this pull request Mar 20, 2017
weierophinney added a commit that referenced this pull request Mar 20, 2017
weierophinney added a commit that referenced this pull request Mar 20, 2017
@weierophinney
Copy link
Member

Thanks, @localheinz

@localheinz localheinz deleted the fix/case branch March 20, 2017 19:12
@localheinz
Copy link
Member Author

Thank you, @weierophinney!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants