Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fixed incorrect alias names #11

Closed
wants to merge 1 commit into from
Closed

Conversation

svycka
Copy link

@svycka svycka commented Nov 6, 2015

@weierophinney
Copy link
Member

Both are required to allow both v2 and v3 usage; can you update to include both, please?

@weierophinney weierophinney added this to the 2.0.1 milestone Jan 25, 2016
@weierophinney weierophinney self-assigned this Jan 25, 2016
@svycka
Copy link
Author

svycka commented Jan 25, 2016

@weierophinney updated, is it ok?

@svycka
Copy link
Author

svycka commented Jan 25, 2016

not sure about this:

    protected $invokableClasses = [
        'arrayserializable' => 'Zend\Hydrator\ArraySerializable',
        'classmethods'      => 'Zend\Hydrator\ClassMethods',
        'objectproperty'    => 'Zend\Hydrator\ObjectProperty',
        'reflection'        => 'Zend\Hydrator\Reflection'
    ];

maybe also add aliases?

@weierophinney
Copy link
Member

@svycka That should be broken into aliases and factories (using InvokableFactory). The factory definitions should have both FQCN and canonicalized name keys; all short names should be defined as aliases, pointing to the FQCN, and should be done as all lowercase, camelCase, and TitleCase to hit the majority of use cases.

@svycka
Copy link
Author

svycka commented Jan 26, 2016

@weierophinney one more question should I add validate() method to support v3? or this should be done in another PR with all other changes for SMv3?

@svycka
Copy link
Author

svycka commented Jan 26, 2016

Also not sure if I can use ::class here.

@weierophinney
Copy link
Member

Also not sure if I can use ::class here.

Absolutely; minimum PHP version is 5.5, which is the version introducing that magic constant. 😄

@weierophinney
Copy link
Member

one more question should I add validate() method to support v3? or this should be done in another PR with all other changes for SMv3?

Go ahead and do it in this one, and change the title to reflect that it's doing a full v2/v3 compatibility changeset.

@svycka
Copy link
Author

svycka commented Feb 3, 2016

@weierophinney I think @kynx did a lot of work for V3 support in #17 so I think I will not duplicate the same :-)

@svycka svycka closed this Jul 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants