This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fix performance issues using sm3 configure() #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using v3 configure method if available and adding all services/factories/aliases... in one go. fixes the performance issues i reported earlier: zendframework/zend-servicemanager#122 zendframework/zend-expressive-zendviewrenderer#25 zendframework#76
pine3ree
added a commit
to pine3ree/zend-i18n
that referenced
this pull request
May 27, 2016
to prevent any performance overhead. (same reasons for zendframework/zend-form#77)
This was referenced May 27, 2016
| $serviceManager->setAlias($alias, $target); | ||
| if (method_exists($serviceManager, 'configure')) { | ||
| $serviceManager->configure($config); | ||
| } else { |
There was a problem hiding this comment.
Use an early return here, please
|
@Ocramius |
weierophinney
added a commit
that referenced
this pull request
Jun 7, 2016
fix performance issues using sm3 configure()
weierophinney
added a commit
that referenced
this pull request
Jun 7, 2016
weierophinney
added a commit
that referenced
this pull request
Jun 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using v3 configure method if available and adding all services/factories/aliases... in one go.
fixes the performance issues i reported earlier:
zendframework/zend-servicemanager#122
zendframework/zend-expressive-zendviewrenderer#25
#76