This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Compare against DateTimeInterface in DateTime::getValue #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking whether Element\DateTime’s value is an actual PHP DateTime, it’s more useful to check if it’s an instance of DateTimeInterface, since such approach allows to use either DateTime or DateTimeImmutable object as element value.
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
…e-element Compare against DateTimeInterface in DateTime::getValue
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
|
Thnaks, @gscscnd |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking whether
Element\DateTime’s value is an actual PHPDateTime, it’s more useful to check if it’s an instance ofDateTimeInterface, since such approach allows to use eitherDateTimeorDateTimeImmutableobject as element value.