pimple protect factory

[pine3ree]

storing object having a callable __invoke() method requires using Pimple::protect().... I (foolishly) forgot this in my previous commit.

[stubbetje]

Oh yes! I have been trying to debug this issue for to long. This solved it for me.

I was trying to create a factory class that is the factory for a number of objects

namespace App;

use Interop\Container\ContainerInterface;

class FooBarFactory
{
    public function __invoke( ContainerInterface $container, string $name )
    {
        switch( $name ) {
            case Foo::class:
                return new Foo;

            case Bar::class:
                return new Bar;

            default:
                throw new \InvalidArgumentException( '...' ):
        }
    }
}

And in config/dependencies.global.php:

return [
    'dependencies' => [
        'factories' => [
            Foo::class => FooBarFactory::class,
            Bar::class => FooBarFactory::class,
        ],
    ],
];

The first time, FooBarFactory was called like expected, with a fully qualified class name in $name.
But after that initial time, FooBarFactory kept being called without a $name argument.

First I thought it was not supposed to work this way, but when using zendframework/zend-servicemanager, then it works flawlessly.

The suggested change fixes this. So as far as I am concerned, this change should be merged...

Thx @pine3ree for making my day 😄

[pine3ree]

@stubbetje
sorry i forgot this "not unsignificant" detail in my previous PR. It was long time ago, but this pr has not been merged yet: i guess devs have been very busy with zf3 packages upgrade.
kind regards

[weierophinney]

Thanks, @pine3ree