Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Symfony DI container support #182

Closed

Conversation

jsoumelidis
Copy link

Following the latest approach for alternative containers as suggested at #170

@jsoumelidis jsoumelidis changed the base branch from master to develop December 11, 2017 21:55
@jsoumelidis jsoumelidis reopened this Dec 11, 2017
@geerteltink geerteltink added this to the 3.0.0 milestone Dec 12, 2017
@geerteltink
Copy link
Member

Thanx @jsoumelidis. I had a quick look at the code and it looks good to me. Staged for a 3.0 release.

geerteltink added a commit that referenced this pull request Dec 12, 2017
geerteltink added a commit that referenced this pull request Dec 12, 2017
geerteltink added a commit that referenced this pull request Dec 12, 2017
@geerteltink
Copy link
Member

Merged into release-3.0.0. Thanx @jsoumelidis!

@jsoumelidis
Copy link
Author

:)
I noticed that a file used by the old approach is still there.
I'll create a new PR that removes file 'src/ExpressiveInstaller/Resources/config/sf-container.global.php'

@geerteltink
Copy link
Member

I just found that file while refactoring a bit. I couldn't figure out why it was there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants