This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Do not act as a route result observer #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the `UrlHelper` such that it no longer acts as a route result observer. The `UrlHelperMiddleware` was updated to look for the `RouteResult` attribute, and, if present, inject the `UrlHelper` via its `setRouteResult()` property. These changes: - are not backwards compatible, and will require a new major version. - require merging of zendframework/zend-expressive#270 for the middleware updates to work.
|
Note that this is against the develop branch. |
weierophinney
added a commit
that referenced
this pull request
Jan 18, 2016
weierophinney
added a commit
that referenced
this pull request
Jan 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
UrlHelpersuch that it no longer acts as a route result observer. TheUrlHelperMiddlewarewas updated to look for theRouteResultattribute, and, if present, inject theUrlHelpervia itssetRouteResult()property.These changes: