This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Allow varying UrlHelper
for path-segregated middleware
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating path-segregated middleware, you may want to provide middleware-specific routing. Once you do that, however, you need a new
UrlHelper
instance that contains that new router, and which knows the base path to prepend, if you want to generate route-specific URIs.This patch is the first of several that accommodates this scenario.
The approach it uses is to allow optional constructor arguments to each of the
UrlHelperFactory
andUrlHelperMiddlewareFactory
. Usage is as follows:In the above,
Router:class
,UrlHelper::class
, andUrlHelperMiddleware::class
are virtual services, resolving to theApi
namespace. When creating our middleware pipeline, we can now reference theUrlHelperMiddleware
service:Each factory now also implements
__set_state()
, to ensure that configuration caching will work correctly (the default configuration caching usesvar_export()
, which requires that__set_state()
be defined wheninclude
is called).