This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Adopt PHP 7.1 features #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PHP bumped to 7.1. - Use http-interop/http-server-middleware instead of polyfill. - Require zend-expressive-router 3.0.0@dev.
Updates code to use http-server-middleware and http-server-handler interfaces, and conform to their signatures.
Updates all signatures to add return type hints, scalar type hints, and nullable types. The following signatures, in particular, are of interest due to backwards-incompatible changes: - `Zend\Expressive\Helper\BodyParams\StrategyInterface`: - The `match()` signature changes to `match(string $contentType) : bool` - The `parse()` signature changes to `parse(ServerRequestInterface $request) : ServerRequestInterface` - `Zend\Expressive\Helper\ServerUrlHelper` updates its public API to read as follows: - `__invoke(string $path = null) : string` - `generate(string $path = null) : string` - `setUri(UriInterface $uri) : void` - `Zend\Expressive\Helper\UrlHelper` updates its public API to read as follows: - `__invoke(?string $routeName = null, array $routeParams = [], array $queryParams = [], ?string $fragmentIdentifier = null, array $options = []) : string` - `generate(?string $routeName = null, array $routeParams = [], array $queryParams = [], ?string $fragmentIdentifier = null, array $options = []) : string` - `setRouteResult(RouteResult $result) : void` - `setBasePath(string $path) : void` - `getRouteResult() : ?RouteResult` - `getBasePath() : string` All class files now enable strict_types, ensuring scalar types must be honored.
4be44ec to
9a610f9
Compare
weierophinney
added a commit
that referenced
this pull request
Dec 7, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the component to make use of PHP 7.1 features. In particular:
Zend\Expressive\Helper\BodyParams\StrategyInterface:match()signature changes tomatch(string $contentType) : boolparse()signature changes toparse(ServerRequestInterface $request) : ServerRequestInterfaceZend\Expressive\Helper\ServerUrlHelperupdates its public API to read as follows:__invoke(string $path = null) : stringgenerate(string $path = null) : stringsetUri(UriInterface $uri) : voidZend\Expressive\Helper\UrlHelperupdates its public API to read as follows:__invoke(?string $routeName = null, array $routeParams = [], array $queryParams = [], ?string $fragmentIdentifier = null, array $options = []) : stringgenerate(?string $routeName = null, array $routeParams = [], array $queryParams = [], ?string $fragmentIdentifier = null, array $options = []) : stringsetRouteResult(RouteResult $result) : voidsetBasePath(string $path) : voidgetRouteResult() : ?RouteResultgetBasePath() : stringstrict_typesto ensure errors are thrown for invalid scalar values.