This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Use route result observer/subject interfaces from zend-expressive-router #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of zend-expressive. Currently, zend-expressive-router now contains all interfaces against which this component codes against, even for testing.
…sive-router Updates `UrlHelper` to use the `RouteResultObserverInterface` from the zend-expressive-router package instead of from the zend-expressive package. Additionally, updates the `UrlHelperFactory` tests to generate a mock of `RouteResultSubjectInterface` to use for testing the "Application" injection. The tests still specify `Zend\Expressive\Application` in the import statements and when specifying names to the container mock instance. This works, even without the class, due to the fact that PHP resolves the `::class` constant based on the import statements when not operating on an instance.
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the code to use the
RouteResultObserverInterfacefrom zend-expressive-router 1.1.0, vs the one in zend-expressive (as yet unreleased). The change allows the following:RouteResultSubjectInterfaceinstead of zend-expressive'sApplicationclass)This keeps all functionality, making it backwards compatible with 1.0.