Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Added zendframework/zend-config-aggregator-modulemanager as suggestion #18

Merged
merged 8 commits into from
Apr 4, 2018
Merged

Added zendframework/zend-config-aggregator-modulemanager as suggestion #18

merged 8 commits into from
Apr 4, 2018

Conversation

boesing
Copy link
Member

@boesing boesing commented Feb 23, 2018

To use modules which were originally created for zend-mvc, I would like to use a ZendModuleProvider, which parses the zend-mvc structure.

Zend Modules provide configurations by the getConfig method.
They might provide dependencies with the service_manager key or by implementing the ServiceProviderInterface from zendframework/zend-modulemanager.

I created a class which just executes the methods and parse them into the new dependency structure.

@weierophinney
Copy link
Member

This is definitely an awesome idea!

However, I hesitate to add it to this library, which is fairly agnostic about sources. I would suggest instead that this functionality be split into a separate package that users can opt-in to if they want to use zend-mvc modules. If you create the repo, we can fork it or have you assign ownership to the zendframework organization.

Since we want to use the module in e.g. `zendframework/zend-expressive`, we might not want to use controllers either.
…endframework/zend-config-aggregator-modulemanager` extension
@boesing
Copy link
Member Author

boesing commented Feb 27, 2018

I've updated the PR and created a public repository boesing/zend-config-aggregator-modulemanager which could be forked/moved to the zendframework organization.
Feel free to fork or to provide me ownership to the organization.

The project should be integrated into the documentation process, since there are links within the Markdown files which are pointing to the official documentation repository.

@boesing boesing changed the title [Feature] Added ZendModuleProvider to parse Modules created for zend-mvc Added zendframework/zend-config-aggregator-modulemanager as suggestion Mar 14, 2018
@weierophinney weierophinney merged commit 1e2f736 into zendframework:master Apr 4, 2018
weierophinney added a commit that referenced this pull request Apr 4, 2018
weierophinney added a commit that referenced this pull request Apr 4, 2018
weierophinney added a commit that referenced this pull request Apr 4, 2018
Forward port #18

Conflicts:
	CHANGELOG.md
@weierophinney
Copy link
Member

Thanks, @boesing!

@boesing boesing deleted the feature/zend-module-provider branch April 4, 2018 19:57
@boesing
Copy link
Member Author

boesing commented Apr 4, 2018

@weierophinney Please note that the suggested package is not yet available through packagist, since it should be moved/forked into the zendframework organization and then added to packagist.

Same is for #19

@weierophinney
Copy link
Member

I'd added it before merging. ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants