This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently released Mac highSierra OS has changed the order globbed files are returned when using
GLOB_BRACE
. Previously (and on any *nix box I've tried) you'd get something like:On highSierra you get:
According to the libc man page
glob
sorts the file names alphabetically. But clearly this doesn't happen in most implementations when using brace patterns.This PR adds a
GLOB_NOSORT
flag to ensure files are returned in brace order under highSierra. Note files within each brace match will now be returned in filesystem order: if someone were relying on entries inb.global.php
overridinga.global.php
this may not happen.