This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Default to first discovered option #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary use case for this plugin is to automate injection of discovered configuration providers and/or modules. By defaulting to "do not inject", we are essentially undoing such automation. This patch modifies the `ComponentInstaller` class to default to the first provider/module discovered. The implication is that component/module authors should put the most desired location first if defining multiple injection points.
Per @akrabat, the default value for "remember this option" should also be "y".
weierophinney
added a commit
that referenced
this pull request
Feb 6, 2018
- Renames 1.2.0 entry to 2.0.0 - Adds entry to "Changed" section for #49
weierophinney
added a commit
that referenced
this pull request
Feb 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use case for this plugin is to automate injection of discovered configuration providers and/or modules. By defaulting to "do not inject", we are essentially undoing such automation.
This patch modifies the
ComponentInstallerclass to default to the first provider/module discovered. The implication is that component/module authors should put the most desired location first if defining multiple injection points.Since this is a rather significant change in behavior, I'm targeting a v2 release.