Fix SqlComments #334
Merged
Fix SqlComments #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cca5f7 to
2bd37ef
Compare
bquorning
approved these changes
May 12, 2024
angelim
approved these changes
May 12, 2024
`SqlComments` is broken in Rails 7.0 because it now passes an `async` kwarg[^1] when it used to only have the two positional arguments. [^1]:(https://github.com/rails/rails/blob/5873d6279a2b2ec11d0176da66df17b076733791/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L194) The reason I'm using a sublass of `Mysql2Adapter` is so that we can prepend `SqlComments` onto it and use the instance of that custom class to test that the comments are added without adding comments to the rest of the test suite. I've updated the tests to... actually test with Rails. Before it didn't run any Rails code at all.
2bd37ef to
2d78503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlCommentsis broken in Rails 7.0 because it now passes anasynckwarg1 when it used to only have the two positional arguments.I've updated the tests to... actually test with Rails. Before it didn't run any Rails code at all.
Releases the patch as
v5.5.1.Footnotes
(https://github.com/rails/rails/blob/5873d6279a2b2ec11d0176da66df17b076733791/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L194) ↩