Check if shard names are integers when caching the configurations #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83aa878 to
7e8789c
Compare
bquorning
reviewed
Mar 23, 2023
7e8789c to
6e06d35
Compare
We only need to verify that all of the shard names are integers _once_, otherwise we will perform an expensive integer check on every shard name, every time we call `shard_names`.
6e06d35 to
1390e38
Compare
bquorning
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative, or an addition to, #311
We only need to verify that all of the shard names are integers once, otherwise we will perform an expensive integer check on every shard name, every time we call
shard_names.