Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weights #1101

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update weights #1101

merged 1 commit into from
Sep 12, 2023

Conversation

sea212
Copy link
Member

@sea212 sea212 commented Sep 12, 2023

What does it do?

Updates the weights based on the reference machine.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Sep 12, 2023
@sea212 sea212 added this to the v0.4.0 milestone Sep 12, 2023
@sea212 sea212 self-assigned this Sep 12, 2023
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Sep 12, 2023
@sea212 sea212 merged commit bb0e671 into release-v0.4.0 Sep 12, 2023
@sea212 sea212 deleted the sea212-update-weights-v0.4.0 branch September 12, 2023 20:08
@Chralt98
Copy link
Member

Chralt98 commented Sep 15, 2023

If we use the old weight-v1 system by from_ref_time, the nodes won't be able to process those transactions.

sea212 added a commit that referenced this pull request Oct 11, 2023
* Update versions to v0.4.0 (#1098)

* Update weights (#1101)

* Reduce length of `MarketsCollectingSubsidy` (#1118)

* Add bad block of the proof size fiasko to Battery Station chain spec (#1119)

Add bad block to Battery Station chain spec

* Update weights v0.4.0 (#1121)

* Update moonbeam dependencies (bench fix)

* Update weights

* Adapt arbitrage weight calculations to proof sizes (#1120)

Include proof size into arbitrage weight estimates

---------

Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
maltekliemann added a commit that referenced this pull request Oct 11, 2023
* Implement neo-swaps

* Fix compile issues

* Implement `DeployPoolsApi` as noop

* Fix formatting

* Add missing copyright notices

* Fix clippy issues

* Fix more clippy issues and rename `balances` to `reserves`

* Remove `println!`

* Add missing copyright notice

* .

* Add benchmarking and include `NeoSwaps` in Runtime

* Add neo-swaps benchmarks; remove `split` (for now)

* Add benchmarks for `create_market_and_deploy_pool`

* Properly implement `DeployPool`

* Fix benchmarks, remove unnecessary parameter

* Fix formatting

* Fix dependencies

* Add math docs

* Fix typo

* Make me codeowner of neo-swaps

* Add neo-swaps to main README and fix link to PDF

* Fix link

* Update versions to v0.4.0 (#1098)

* Update weights (#1101)

* Remove unnecessary comment from toml

* Use default features

* Bump version

* Use checked math in `SoloLp`

* Make match expression explicit

* Add comment about saturation

* Use `MultiCurrency` instead of `ZeitgeistAssetManager`

* Apply suggestions from code review

Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>

* Remove superfluous inserts

* Fix error documentation

* Abstract reserve updates into `Pool`

* Make complete set operations require transactional

* Make test name not coffee-based

* Update zrml/neo-swaps/src/mock.rs

Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>

* Update zrml/neo-swaps/src/mock.rs

Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>

* Reorganize tests

* Format

* Fix comment

* Remove `macros.rs`

* Fix benchmarks

* Fix formatting

* Update benchmark script and add preliminary benchmarks

* Update ED buffer handling

* Fix documentation

* Implement market creation fees for neo-swaps

* Use `MarketCreatorFee` in runtime

* Add missing files

* Add weights

* Reduce length of `MarketsCollectingSubsidy` (#1118)

* Add bad block of the proof size fiasko to Battery Station chain spec (#1119)

Add bad block to Battery Station chain spec

* Update weights v0.4.0 (#1121)

* Update moonbeam dependencies (bench fix)

* Update weights

* Fix docs

* Rename `IndexType` and change its type value

* Remove commented code

* Fix order of config parameters

* Specify order of assets

* Remove commented code

* Apply suggestions from code review

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Fix `u16`/`u32` casts

* Update zrml/prediction-markets/src/benchmarks.rs

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Update zrml/prediction-markets/src/benchmarks.rs

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Update zrml/neo-swaps/src/math.rs

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Update primitives/src/math/fixed.rs

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Update primitives/src/math/fixed.rs

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Fix formatting

* Fix conflicts

* Fix dispute period

* Format code

---------

Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>
Co-authored-by: Chralt <chralt.developer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants