Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from appf #129

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Updates from appf #129

merged 3 commits into from
Jul 28, 2022

Conversation

ahaith
Copy link
Contributor

@ahaith ahaith commented Jul 27, 2022

Some small modifications to #128:

  • Slightly different way of handling custom mime type map
  • Bump version number

* Allowed for the specification of additional file extension maps to MIME types, including support for no file extension.
* Modified filename_filter to be interpreted as a complete list of files to look for and include, preventing  glob of entire directory.
* Added error-checking for empty (no images included) UploadableSources.
* Added image_details property to source.
* Allowed for the specification of additional file extension maps to MIME types, including support for no file extension.
* Modified filename_filter to be interpreted as a complete list of files to look for and include, preventing  glob of entire directory.
* Added error-checking for empty (no images included) UploadableSources.
Work with a member attribute rather than the class one.
Default to empty dict rather than None.

Bump version

Revert
@ahaith ahaith force-pushed the updates-from-appf branch from b4aad39 to c504b72 Compare July 28, 2022 14:08
@ahaith ahaith merged commit 262651f into main Jul 28, 2022
@ahaith ahaith deleted the updates-from-appf branch July 28, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants