Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved name/filename_col requirements out of empty collection creation #125

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Moved name/filename_col requirements out of empty collection creation #125

merged 3 commits into from
Aug 9, 2022

Conversation

Vaspra
Copy link
Contributor

@Vaspra Vaspra commented Jul 5, 2022

No description provided.

@Vaspra Vaspra requested review from a team as code owners July 5, 2022 14:10
@ahaith
Copy link
Contributor

ahaith commented Jul 5, 2022

A few lint errors:
./zegami_sdk/workspace.py:150:1: W293 blank line contains whitespace
./zegami_sdk/workspace.py:157:1: W293 blank line contains whitespace
./zegami_sdk/workspace.py:163:1: W293 blank line contains whitespace
./zegami_sdk/workspace.py:167:1: W293 blank line contains whitespace
./zegami_sdk/workspace.py:188:82: E502 the backslash is redundant between brackets
./zegami_sdk/workspace.py:266:1: W293 blank line contains whitespace

ahaith
ahaith approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@ahaith ahaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should arguably continue to support uploadable_sources being passed in to avoid it being a breaking change, although I don't think this is in use by anyone except us and George atm.

@tracivar tracivar merged commit 8688d6a into main Aug 9, 2022
@tracivar tracivar deleted the _create_collection-names-only branch August 9, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaith ahaith ahaith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vaspra @ahaith @tracivar