Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zed now always shows horizontal scroll in project panel on macOS #19637

Closed
1 task done
chriskrycho opened this issue Oct 23, 2024 · 1 comment · Fixed by #19767
Closed
1 task done

Zed now always shows horizontal scroll in project panel on macOS #19637

chriskrycho opened this issue Oct 23, 2024 · 1 comment · Fixed by #19767
Labels
bug [core label] macOS Platform-specific feedback for macOS behaviors, features, design, etc project panel Feedback for files tree view

Comments

@chriskrycho
Copy link

chriskrycho commented Oct 23, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

On macOS, the project panel now always has a horizontal scroll bar (as of 0.158.1), regardless of whether or not the area has any additional scroll area. I have checked this with all the variations in System Settings > Appearance > Show scroll bars and it works the same in all of them.

Environment

Zed: v0.158.1 (Zed)
OS: macOS 14.7.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

CleanShot.2024-10-23.at.13.21.20-converted.mp4

If applicable, attach your Zed.log file to this issue.

No response
@chriskrycho chriskrycho added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Oct 23, 2024
@chriskrycho chriskrycho changed the title Zed Horizontal Scroll Zed now always shows horizontal scroll in project panel on macOS Oct 23, 2024
@github-actions github-actions bot mentioned this issue Oct 24, 2024
Open
This was referenced Oct 25, 2024
Closed
Merged
Closed
SomeoneToIgnore added a commit that referenced this issue Oct 26, 2024
@SomeoneToIgnore
Restore horizontal scrollbar checks (#19767)
2e32f1c 
Closes #19637

Follow-up of #18927 , restores
the condition that removed the horizontal scrollbar when panel's items
are not long enough.

Release Notes:

- Fixed horizontal scrollbar not being hidden
([#19637](#19637))
SomeoneToIgnore added a commit that referenced this issue Oct 26, 2024
@SomeoneToIgnore
Restore horizontal scrollbar checks (#19767)
40f519b 
Closes #19637

Follow-up of #18927 , restores
the condition that removed the horizontal scrollbar when panel's items
are not long enough.

Release Notes:

- Fixed horizontal scrollbar not being hidden
([#19637](#19637))
SomeoneToIgnore added a commit that referenced this issue Oct 26, 2024
@SomeoneToIgnore
Restore horizontal scrollbar checks (#19767)
0798c64 
Closes #19637

Follow-up of #18927 , restores
the condition that removed the horizontal scrollbar when panel's items
are not long enough.

Release Notes:

- Fixed horizontal scrollbar not being hidden
([#19637](#19637))
@notpeter notpeter added macOS Platform-specific feedback for macOS behaviors, features, design, etc project panel Feedback for files tree view and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Oct 28, 2024
@chriskrycho
Copy link
Author

Thanks for fixing it!

CharlesChen0823 pushed a commit to CharlesChen0823/zed that referenced this issue Nov 18, 2024
@SomeoneToIgnore @CharlesChen0823
Restore horizontal scrollbar checks (zed-industries#19767)
73724b1 
Closes zed-industries#19637

Follow-up of zed-industries#18927 , restores
the condition that removed the horizontal scrollbar when panel's items
are not long enough.

Release Notes:

- Fixed horizontal scrollbar not being hidden
([zed-industries#19637](zed-industries#19637))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] macOS Platform-specific feedback for macOS behaviors, features, design, etc project panel Feedback for files tree view
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore horizontal scrollbar checks zed-industries/zed
2 participants
@notpeter @chriskrycho