Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reasonml syntax #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add reasonml syntax #5

wants to merge 2 commits into from

Conversation

Khady
Copy link
Contributor

@Khady Khady commented Dec 4, 2024

Initiating support for #4

Copy link

cla-bot bot commented Dec 4, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @Khady on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Khady
Copy link
Contributor Author

Khady commented Dec 4, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 4, 2024
Copy link

cla-bot bot commented Dec 4, 2024

The cla-bot has been summoned, and re-checked this pull request!

@notpeter
Copy link
Contributor

notpeter commented Dec 4, 2024

You'll need to add language folders for reason_ml and reason_ml_interface including config.toml to associate file extensions with the grammars. Then you'll also want to include the relevant tree-sitter queries (*.scm) as well.

Look at the other languages/ folders for examples.

And Developing Zed Language Extensions in the docs for more.

@Khady
Copy link
Contributor Author

Khady commented Dec 6, 2024

Getting an error in zed's log when trying to install the extension with the additional reason grammar. But it's not obvious what is zed running to compile the grammar.

Caused by:
    failed to compile reasonml parser with clang: wasm-ld: warning: creating shared libraries, with -shared, is not yet stable
    wasm-ld: error: symbol exported via --export not found: tree_sitter_reasonml
    clang: error: linker command failed with exit code 1 (use -v to see invocation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants